[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oddity with svn diff on moved/renamed files.

From: Bas Mevissen <ml_at_basmevissen.nl>
Date: 2004-04-09 15:40:17 CEST

Ben Collins-Sussman wrote:
> But what about the use case of just wanting to see your local mods? My
> impression is that people run 'svn diff' for that purpose much more
> often than they run 'svn diff' to generate a patch. I certainly do.
> I don't think we should completely toss one use-case away. The status
> quo breaks the ability to create patches, and your proposal breaks the
> ability to see local mods.
> I guess what I was thinking was (maybe?) we choose a default behavior,
> and add some sort of new option to 'svn diff' that toggles the other
> behavior. Is that crazy?

OK, some thoughts:

1) The current behaviour of only showing the minus (with the option to
hide it) is neither fish nor fowl. I think this is a bad default.

2) Using svn diff for showing local mods is imcomplete now. Because you
want to see that you have moved/renamed a file, even if you haven't
modified it. I would propose to add some diff-comment like "foo.c got
renamed to bar.c" to the output.

3) Having both plus and minus is needed for a good diff and will not
disturd the human raeding back his changes too much.

So I would propose to have both + and - by default and the option to
switch them off both and replace them by the comment line as prosed at
the second ).

BTW. how does svn diff behave when you use an external diff program?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 9 15:37:02 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.