[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: bad output format design issue: svn log -v format is not parseable :-(

From: Travis P <svn_at_castle.fastmail.fm>
Date: 2004-04-05 18:19:21 CEST

On Apr 5, 2004, at 11:06 AM, C.A.T.Magic wrote:

> patch1: svn status -v now truncates long usernames to the specified 12
> characters to prevent ambiguity like in
> >svn status -v
> > 11 11 cat a file.txt
> > 12 12 administrator johnMy spaced File.c
>
> - printf ("%c%c%c%c%c %c %6s %6s %-12s %s\n",
> + printf ("%c%c%c%c%c %c %6s %6s %-12.12s %s\n",

How'd you get 12 above? Wouldn't there be a space between john and My?
(There is a space in the format string prior to the final %s.)
Truncation of user names will naturally create new ambiguities between,
e.g.
   "administrator john" and "administrator sally" who will both appear
as "administrato"
Given your other patch, I would think you'd want to just use tab
between user name and file name.
(Not that either of these is necessarily good for Subversion trunk.
Not sure why you aren't exploring the XML output option.)

-Travis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 5 18:22:22 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.