On Apr 3, 2004, at 12:41 PM, Justin Erenkrantz wrote:
> --On Saturday, April 3, 2004 2:28 PM -0300 Nicolás Lichtmaier
> <nick@reloco.com.ar> wrote:
>
>> Adaptations for i18n.
>> * Marked up internationalizable strings with _()/N_().
>> * subversion/libsvn_subr/opt.c
>> (print_command_info,svn_opt_format_option): Pass help strings to
>> gettext before printing them.
>
> Note that you are still modifying the apr_signal() call. Why?
>
> To help make the patch smaller, I'd suggest splitting it up into two:
> one which does the _()/N_() and gettext call, and another which
> updates the es.po file. They can be treated orthogonally and would
> shrink the size of the _() patch by a bit so it can be more easily
> reviewed. -- justin
Also, I'm not sure we can just unconditionally add calls to gettext, if
I'm reading the headers right we also need to add a compat #define for
the non-nls case.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 3 19:59:10 2004