[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9280 - in trunk/subversion: include libsvn_delta

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-04-03 19:13:37 CEST

Branko Čibej wrote:
> bliss@tigris.org wrote:
>>* subversion/include/svn_types.h
>> (SVN_STREAM_CHUNK_SIZE): Reduce from 100 kiB to 8 kiB.
>> (SVN_MAX_OBJECT_SIZE): Remove strange FIXME.
> I object to this last bit. It is not a "strange FIXME", it's a question
> that needs to be answered before doing anything about it. Just removing
> the comment doesn't answer the question, and you didn't even try to
> analyse the pros and cons of making max-window-size the same as
> stream-chunk-size.

(I think you meant max-object-size, not max-window-size.)

How about removing SVN_MAX_OBJECT_SIZE and replacing it with something
that makes sense? I don't see how you can have a compile time limit on
what is a sensible maximum object size. An object can be anything.

The limit is currently used for only one thing in the code, namely to
sanity check the size of a rep in the fs code. Renaming it to
SVN_MAX_REP_SIZE would make it easier to assign a reasonable size to it.

Does this sound OK, and do you have a suggestion for a good max rep size?

>>* subversion/libsvn_delta/text_delta.c
>> (SVN_DELTA_WINDOW_SIZE): New define to use for the svndiff window
>> size instead of SVN_STREAM_CHUNK_SIZE.
>> (svn_txdelta, svn_txdelta_next_window): Use SVN_DELTA_WINDOW_SIZE.
> I believe you missed at least fs-test. Your change modifies the
> semantics of the file integrity tests.

I wouldn't commit it if not all tests had passed. What do you mean?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 3 19:14:12 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.