Re: [PATCH][repost] Don't add extra blank line to log messages

kfogel@collab.net wrote:
> This seemed to be posted twice, and Mike Pilato already responded to
> the first one, but I'll respond here just to make sure:

Yes, sorry about that, when the first mail hadn't appeared on the list
after 24 hours I re-sent it, and then of course the original mail arrived
5 minutes later. :P

> No need for a patch -- this is almost certainly pilot error.
>
> The first log message (from the command line) does not contain a
> newline. The second one (made with $EDITOR) does. If you make
> *absolutely sure* that your editor saves the log message without any
> newline -- some editors automatically ensure one at the end of a file,
> so be careful! -- then you will see the 'svn log' output is the same
> as with the -m"Oneliner comment" method.

The output from $EDITOR contains this:

---------start cut'n'paste---------
Oneliner comment
--This line, and those below, will be ignored--

M foobar
----------end cut'n'paste----------

So, the current code removes the comments at the end, but leaves a
newline. That is what my patch tries to fix.

 -- Patrik Rådman

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 31 19:44:53 2004