[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][REPOST] Don't add extra blank line to log messages

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-03-29 03:56:07 CEST

Patrik RÃ¥dman <pradman@abo.fi> writes:

> C. Michael Pilato <cmpilato@collab.net> wrote:
> [snip]
> >
> > ### Finally, I change the file again, and commit using $EDITOR. My
> > ### editor pops up and I type "No extra lines, please", then strip all
> > ### the rest of the junk out of the file -- including the newline at
> > ### the end of my message. Again, this is to ensure a fair comparison.
>
> Uh... So your opinion is that the user should always have to do the
> tedious work of deleting the lines from "--This line, and those below,
> will be ignored--" onwards? Why, when it's so easy to patch the svn client
> to completely remove them?
>
> In my opinion the line isn't "ignored" in the current code, it's turned
> into a blank line. :)

Cute, but that's not what's going on. If I make a commit and my
$EDITOR log message looks thusly:

   No extra lines, please.
   --This line, and those below, will be ignored--
   
   M foo

I should expect that my log message has exactly one EOL marker -- the
one after "please." and before "--This". So let's see if that's the
case:

   $ svnlook info repos
   cmpilato
   2004-03-28 19:51:57 -0600 (Sun, 28 Mar 2004)
   24
   No extra lines, please.
   
   $

'svnlook info' tells me that my log message contains 24 characters.
That's 23 characters for "No extra lines, please." plus 1 EOL
character -- exactly what I expected.

What is causing confusion is that 'svn log' (and 'svnlook info' and
'svnlook log', for that matter) *always* prints an extra newline just
in case your log message *didn't* end in one (so that formatting
doesn't get all wonky). Nobody wants to see:

   $ svn log
   ------------------------------------------------------------------------
   r4 | cmpilato | 2004-03-28 19:47:35 -0600 (Sun, 28 Mar 2004) | 1 line
   
   No extra lines, please.------------------------------------------------------------------------
   r3 | cmpilato | 2004-03-27 14:44:44 -0600 (Sat, 27 Mar 2004) | 1 line
   ...

Know what I mean?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 29 03:57:29 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.