[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [Issue 1751] file not switched if it is the same in source and destination

From: makl <makl_at_tigris.org>
Date: 2004-03-24 07:15:19 CET

Philip Martin wrote:
> makl <makl@tigris.org> writes:
>
>
>>Index: subversion/libsvn_wc/adm_ops.c
>>===================================================================
>>--- subversion/libsvn_wc/adm_ops.c (revision 9193)
>>+++ subversion/libsvn_wc/adm_ops.c (working copy)
>
>
>>@@ -200,20 +202,13 @@
>> SVN_ERR (svn_wc_adm_retrieve (&dir_access, adm_access, path, pool));
>>
>> if (! recursive)
>>- {
>>- svn_boolean_t write_required = FALSE;
>>- SVN_ERR (svn_wc_entries_read (&entries, dir_access, TRUE, pool));
>>- SVN_ERR (svn_wc__tweak_entry (entries, SVN_WC_ENTRY_THIS_DIR,
>>- base_url, new_revision, &write_required,
>>- svn_wc_adm_access_pool (dir_access)));
>>- if (write_required)
>>- SVN_ERR (svn_wc__entries_write (entries, dir_access, pool));
>>- }
>>+ SVN_ERR (tweak_entries (dir_access, base_url, new_revision,
>>+ NULL, NULL, FALSE,
>>+ FALSE, pool));
>
>
> Why is this passing FALSE for remove_missing_dirs (and thus NULL for
> the notify stuff)? I'm not saying it's wrong, I just don't understand
> it.

remove_missing_dirs and the notify stuff are only used in the recursive
case. Passing them as FALSE and null, everyone can see at the first
sight that they are irrelevant for the non-recursive case.

I have no problem if you prefer one function call and loosing the
"if(!recursive)".

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 24 07:13:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.