r9077 is a bug fix which sets the transaction author (if previously unset) and
blocks multi-author commit. You've nominated r9077 for backport to the 1.0.x
branch, and it generally seems like a great candidate. One comment -- my
reading of RFC2616 indicates that a 501 status code would be more appropriate
than a 500 for attempts at unsupported operations. I'd like this change to be
part of the r9077 backport nomination. Thoughts?
* subversion/mod_dav_svn/repos.c
(dav_svn_prep_working): For attempted unsupported operations like
multi-author commits, return a 501 (Not implemented) rather than
a 500 (Internal server error).
Index: subversion/mod_dav_svn/repos.c
===================================================================
--- subversion/mod_dav_svn/repos.c (revision 9195)
+++ subversion/mod_dav_svn/repos.c (working copy)
@@ -712,7 +712,7 @@
}
else if (!svn_string_compare(current_author, &request_author))
{
- return dav_new_error(pool, HTTP_INTERNAL_SERVER_ERROR, 0,
+ return dav_new_error(pool, HTTP_NOT_IMPLEMENTED, 0,
"Multi-author commits not supported.");
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 24 01:13:30 2004