Re: Missing error messages with svn_error_quick_wrap [was: Re: " Inconsistent line-endings"]

On Sat, 2004-03-20 at 11:04, Julian Foad wrote:
> "svn_error_quick_wrap" creates a wrapper error with the same error
> code as the wrapped error. If the wrapped error doesn't have an
> explicit message, "svn_handle_error" then doesn't print it at all
> (apart from the file and line debugging info).

> I think the best solution is for "svn_error_quick_wrap" to use the
> error code SVN_ERR_BASE rather than copy the wrapped error code. The
> default text for SVN_ERR_BASE is "A problem occurred; see later errors
> for details", which is exactly what "svn_error_quick_wrap" is for.

Hm, that doesn't seem right. The wrapped error should be recognizable
programmatically as the same kind of error as the one being wrapped.

I think the svn_handle_error behavior for this case is probably historic
and unjustified; it would be better to change the handling behavior than
the wrapping behavior.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 21 19:14:02 2004