Re: [PATCH] Keyword hash and Properties as keyword

Philip Martin wrote:
>> /** Values used in keyword expansion. */
>>-typedef struct svn_subst_keywords_t
>>-{
>>- const svn_string_t *revision;
>>- const svn_string_t *date;
>>- const svn_string_t *author;
>>- const svn_string_t *url;
>>- const svn_string_t *id;
>>-} svn_subst_keywords_t;
>>+typedef apr_hash_t svn_subst_keywords_t;
>
>
> I haven't looked at the rest of the patch, but this jumped out. This
> is an ABI change just as much as changing a function signature and so
> it cannot go into 1.1. If you want to put this feature into 1.1. you
> will need to use a new type.
>

Yup, I figured as much. I wanted to get the rest of the patch out there to
discuss how to best go about that. If there is a lot of resistance to the
"property as keyword" feature itself, I don't want to spend too much [more] time
upfront without knowing that first. Once we hash out whether this is suitable
at all, I can work on how to make it ABI compatible...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org