Re: svn commit: r9150 - trunk/subversion/libsvn_client

On Fri, Mar 19, 2004 at 01:31:36PM -0600, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_client/prop_commands.c Fri Mar 19 13:30:11 2004
> @@ -205,8 +205,11 @@
> void *ra_baton, *session;
> svn_ra_plugin_t *ra_lib;
>
> - if (strcmp (propname, SVN_PROP_REVISION_AUTHOR) == 0
> - && strchr (propval->data, '\n') != NULL && !force)
> + if ((strcmp (propname, SVN_PROP_REVISION_AUTHOR) == 0)
> + && propval
> + && propval->data

propval->data can't be NULL, so this check is extraneous. If we had to
add that check everywhere... eesh. :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org