Re: Making propchange-email.pl send diffs

Ben Reser wrote:
> On Thu, Mar 18, 2004 at 11:53:30AM +0100, Juanma Barranquero wrote:
>
>>On Wed, 17 Mar 2004 16:36:03 -0800
>>Ben Reser <ben@reser.org> wrote:
>>
>>>Dumb question, but why don't you just do the actual diff in the
>>>pre-revprop? You have access to the new proval as STDIN?
>>
>>No, he doesn't, unless someone fixed Issue #952 recently.
>
> Humm shouldn't the .tmpl file umm say that then?

It's rather naughty that we've been creating hook templates that say this, when it's never been true (it was unimplemented, not just broken). Fixing the comment now will have only limited effect: it will not change the templates in existing repositories. If we start writing templates that say there is a problem, and then we fix the problem, those templates will forever remain in people's repositories that are created in the meantime.

Perhaps, instead of creating hook templates in the repository, we should instead install them with the program (so they will be updated when new versions of the program are installed), and in the repository hooks directory put just a README file which refers to the installed location of the templates. That way, they can be updated to keep up with new features in the program.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 19 04:48:37 2004