Have to agree with Philip. We can't just make it do nothing on Unix;
introducing a deprecator would be fine, though...
-K
Philip Martin <philip@codematters.co.uk> writes:
> Although this is technically not an ABI change I think it needs to be
> treated as such. You have just broken any application that relies on
> the behavior of svn_io_set_file_read_write, and while we may not like
> the interface it was documented and implemented.
>
> I think we have to keep the old implementation under the old name, and
> introduce a new function name with the new behaviour. By all means
> write more explicit documentation disparaging the old interface ;-)
>
> Note to those new to the discussion: Ben's change is really attractive
> if we ignore the problem above. Not only does it reduce disk IO
> (although it was too small a change to be significant last time I
> measured it), it also allows multiple Unix users to share a working
> copy. Oddly enough the shared working copy problem was caused by
> setting files read-write rather than be setting them read-only!
>
> There are some corner cases to shared working copies that still won't
> work, but they are unlikely. To fix them when open_adm_file opens a
> file with APR_WRITE it needs to use APR_EXCL and if that fails because
> the file exists it needs to delete and retry.
>
> --
> Philip Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 17 00:13:15 2004