On Tue, Mar 16, 2004 at 10:46:44PM +0000, Philip Martin wrote:
> breser@tigris.org writes:
>
> > Author: breser
> > Date: Tue Mar 16 16:05:39 2004
> > New Revision: 9085
> >
> > Modified:
> > trunk/subversion/include/svn_io.h
> > trunk/subversion/libsvn_subr/io.c
> > trunk/subversion/libsvn_wc/adm_files.c
> > trunk/subversion/libsvn_wc/adm_ops.c
> > Log:
> > Make svn_io_set_file_read_write() a no op on everything but Windows. We don't
> > really need it on Unix. And due to the behavior of apr_file_attrs_set it does
> > the equivalent of chmod a+w on Unix which is bad.
> >
> > * subversion/include/svn_io.h
> > Document that svn_io_set_file_read_write() does nothing on Unix.
>
> Although this is technically not an ABI change I think it needs to be
> treated as such. You have just broken any application that relies on
> the behavior of svn_io_set_file_read_write, and while we may not like
> the interface it was documented and implemented.
>
> I think we have to keep the old implementation under the old name, and
> introduce a new function name with the new behaviour. By all means
> write more explicit documentation disparaging the old interface ;-)
This was originally my opinion. But everyone told me I was wrong off
list. If people feel differently due to the issue not being a security
issue now then I'll be happy to make a different function.
--
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 16 23:59:36 2004