Re: [PATCH] stdlib removed from svn_types.h

I'm sorry, I mistakenly sent this to Julian Foad. Here I'm sending this
again, to the dev list.

El mié, 10-03-2004 a las 14:11, Julian Foad escribió:
> H. Hernan Moraldo wrote:
> > Remove the #include <stdlib.h> line from svn_types.h, and add that
line
> > to any other files that actually need it.
> [...]
> > On subversion/include/svn_types.h there were some lines telling:
> >
> > /* ### this should go away, but it causes too much breakage right
now */
> > #include <stdlib.h>
>
> Very nearly OK ... but there is one macro that needs stdlib.h:
>
> /** Convert null-terminated C string @a str to a revision number. */
> #define SVN_STR_TO_REV(str) ((svn_revnum_t) atol(str))

According to the replies, I think there are three choices:

1- To keep it all just as it is now

2- To covert SVN_STR_TO_REV to a function, and that would be major
breakage for real, just as pointed in the original commentary. If you
say this is the preferred option, I can try working on this patch.

3- The third option is the one drafted on the patch attached: we don't
remove stdlib from svn_types.h, but we stop assuming it is included
automatically by including svn_types.h on the other source files. I
think this makes for better code, but couldn't know if you agree on
this.

Opinions?

Best regards,

-- 
H. Hernan Moraldo
Moraldo Games
http://games.moraldo.com.ar/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org