[I hope you don't mind me forwarding this to the "dev@" list. I want to keep the discussion there, but I forgot to set "Reply-To" on the previous message I sent.]
-------- Original Message --------
Subject: Re: [PATCH] stdlib removed from svn_types.h
Date: Thu, 11 Mar 2004 18:49:13 -0300
From: H. Hernan Moraldo <games@moraldo.com.ar>
Reply-To: games@moraldo.com.ar
Organization: Moraldo Games
To: Julian Foad <julianfoad@btopenworld.com>
References: <1078898892.29798.22.camel@linmachine> <404F4C35.5090003@btopenworld.com>
El mié, 10-03-2004 a las 14:11, Julian Foad escribió:
> H. Hernan Moraldo wrote:
> > Remove the #include <stdlib.h> line from svn_types.h, and add that line
> > to any other files that actually need it.
> [...]
> > On subversion/include/svn_types.h there were some lines telling:
> >
> > /* ### this should go away, but it causes too much breakage right now */
> > #include <stdlib.h>
>
> Very nearly OK ... but there is one macro that needs stdlib.h:
>
> /** Convert null-terminated C string @a str to a revision number. */
> #define SVN_STR_TO_REV(str) ((svn_revnum_t) atol(str))
According to the replies, I think there are three choices:
1- To keep it all just as it is now
2- To covert SVN_STR_TO_REV to a function, and that would be major
breakage for real, just as pointed in the original commentary. If you
say this is the preferred option, I can try working on this patch.
3- The third option is the one drafted on the patch attached: we don't
remove stdlib from svn_types.h, but we stop assuming it is included
automatically by including svn_types.h on the other source files. I
think this makes for better code, but couldn't know if you agree on
this.
Opinions?
Best regards,
--
H. Hernan Moraldo
Moraldo Games
http://games.moraldo.com.ar/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 12 00:51:16 2004