Re: [PATCH] stdlib removed from svn_types.h

Ben Reser wrote:
> On Wed, Mar 10, 2004 at 03:24:24AM -0300, H. Hernan Moraldo wrote:
>
>>On subversion/include/svn_types.h there were some lines telling:
>>
>>/* ### this should go away, but it causes too much breakage right now */
>>#include <stdlib.h>
>>
>>I removed that include and added that line to all other files that
>>required that to compile. As far as I could see, it worked perfectly,
>>but I still wonder whether that change was wanted by the SVN
>>developers for real.
>>
>>Anyway, here is the patch. Thanks to the SVN developers for this great
>>tool, I really appreciate your work!
>
> If it breaks our clients it's likely to break other clients. I don't
> think we should make this change.

It doesn't break our client. I tried it and it compiled and passed the regression tests. That "###" comment is from some long-ish time ago, and we don't know what kind of breakage it meant anyway.

I guess you mean that it breaks source-code compatibility, which isn't allowed until the next major version.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 11 14:10:06 2004