Re: Issue #1756 -- import doesn't handle svn:eol-style or svn:keywords

Greg Hudson <ghudson@MIT.EDU> writes:
> As always, I am -1 on any Subversion default which destroys data in
> svn:eol-style=native files. So, this change does not belong on the
> trunk as I understand it.

Following Julian's most recent tweak on trunk, let's try to summarize.
My understanding is that with trunk code now, a file with inconsistent
line endings behaves like so:

   - commit w/ svn:eol-style==native does not repair, thus fails
   - add+commit w/ svn:eol-style==native does not repair, thus fails
   - import w/ svn:eol-style==native does not repair, then ???

The "???" means "Does it fail, or does it just get committed as-is,
with inconsistent line endings?"

If it fails, then we have consistency, and no danger of committing
something the user didn't want committed (either they should turn off
the prop, or fix the file contents).

That seems like a fine situation, and is in keeping with the idea of
not destroying data.

Assuming this summary is accurate, does anyone think the current trunk
situation is undesirable?
 
> (If people want to introduce a --repair-newlines option which performs
> the data-destroying transformation for such files, I'm fine with that.)

Agreed, though not in 1.0.x of course.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 19:40:53 2004