[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8935 - branches/1.0.x

From: <kfogel_at_collab.net>
Date: 2004-03-09 18:20:17 CET

Sander Striker <striker@apache.org> writes:
> > @@ -93,9 +96,13 @@
> > filesystem per connection.
> > Votes:
> > +1: striker
> > + -0: kfogel (Reviewed the change; it's not *so* trivial, and I'm
> > + not sure an optimization like this belongs in a
> > + patch release.)
>
> Aw come on :) ;). It's just allocating out of a different pool
> (connection instead of request), and retrieving an item from a table (or
> putting one there if it wasn't previously). Pretty trivial. Especially
> since the same pattern exists in mod_dav_svn.
> Don't be put off by the fact that it's spread out over 3 revs. The
> first is the gist, the second only a change of the key, and the third
> a change of return value in that code block since the function
> containing it was refactored.

Safety first, scouts :-).

(It's mainly that this is 1.0.1, not 1.1.0.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 19:27:15 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.