[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8950 - trunk/subversion/libsvn_client

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-03-09 18:34:42 CET

Hi.

Reading the thread and the commit mail I don't understand something, so I'm
just posting if you're both talking about the same thing. From the thread:

> > What I didn't say explicitly is that I am wholly in favour of what I
> > believe was the intent of this patch, and was merely pointing out
> > that the patch is not quite right: it should not request repair
> > (which is just a matter of changing a "TRUE" to "FALSE").
>
> The decision to not repair line-endings was admittedly somewhat
> arbitrary. In retrospect, I think repairing the line endings is
> fine.

Which says "*not* to repair" by cmpilato, who then agrees to start
repairing. Whereas the "TRUE" in the text from Julian *is* repairing and he wants to
change it to *not* repairing. Followed by this commit:

> Modified:
> trunk/subversion/libsvn_client/commit.c
> Log:
> Never "repair" inconsistent EOL style during an import. Part of issue
> 1756.

So did you guys agree on repairing or on not-repairing?!

bye,

Erik.

-- 
+++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++
100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 18:35:08 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.