Re: Issue #1756 -- import doesn't handle svn:eol-style or svn:keywords

C. Michael Pilato wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>What I didn't say explicitly is that I am wholly in favour of what I
>>believe was the intent of this patch, and was merely pointing out
>>that the patch is not quite right: it should not request repair
>>(which is just a matter of changing a "TRUE" to "FALSE").
>
> The decision to not repair line-endings was admittedly somewhat
> arbitrary. In retrospect, I think repairing the line endings is
> fine.

Oops. I had first read your reply as "I think refusing to repair the line endings is fine", and therefore thought you were saying you would be happy for me to modify it, and so I did. I'm sorry. I was just replying to this mail when I read your words and noticed my misunderstanding. Grrr. Now what?

Why do you think repairing the line endings is fine? It is inconsistent with "commit". Do you think commit should repair them too, or do you think it is right for them to behave differently? Or did you just mean that it is fine for now, because the patch is an improvement over not having the patch, and the "repairing" issue is just a further, minor issue that can be addressed later?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 9 18:06:29 2004