[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: PATCH: error leaks

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-03-08 01:38:15 CET

Philip Martin wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>> Index: subversion/libsvn_fs/fs.c
>>===================================================================
>>--- subversion/libsvn_fs/fs.c (revision 8913)
>>+++ subversion/libsvn_fs/fs.c (working copy)
>>@@ -582,7 +582,7 @@ svn_fs_create_berkeley (svn_fs_t *fs, co
>> return SVN_NO_ERROR;
>> error:
>>- (void) cleanup_fs (fs);
>>+ svn_error_clear (cleanup_fs (fs));
>
> Your change is OK, but there is an SVN_ERR in the function that could
> bypass the error: label. I really think Subversion should avoid this
> particular goto construct as it's too easy to introduce an SVN_ERR,
> but that doesn't mean you should not apply your patch.

Yes - yuck.

That's a separate issue, so committed this patch as r8923. Thanks for the review.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 8 01:37:27 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.