r8708 applies a patch like this to three Perl hook scripts:
-# The warning switch is set here and not in the shebang line above
-# with /usr/bin/env because env will try to find the binary named
-# 'perl -w', which won't work.
-BEGIN
- {
- $^W = 1;
- }
-
+require 5.6.0; # minimum Perl version for "warnings" module
+use warnings;
Some time ago, Ben Collins-Sussman and I looked at this and wondered
why the "require 5.6.0;" line wasn't controversial. Ben Reser
mentioned once that it wasn't, but I don't remember if he said why.
Was it that the scripts already effectively require Perl 5.6.0 (by
virtue of depending on some feature), so making the requirement
explicit doesn't actually add any restrictions? Or was there some
other reason why forcing >= 5.6.0 is okay?
Oh, and, why am I asking this now? :-)
Because Mike Pilato and I were looking at r8708 in 1.0.x/STATUS, to
possibly vote on it. However, we want to make sure that it's not
adding a Perl version requirement that we didn't previously have. Or,
if it *is* adding a requirement, then it's one that's been discussed &
agreed on. We couldn't find anything in the list archives, so we're
asking here.
Thanks,
-Karl & Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 3 08:02:04 2004