Re: More pre-revprop-change hook woes

Juanma Barranquero wrote:

>On Tue, 17 Feb 2004 14:09:07 +0100
>Juanma Barranquero <jmbarranquero@wke.es> wrote:
>
>
>
>>This simple pre-revprop-change.bat hook:
>>
>>
>
>[Somewhat related]
>
>From check_hook_cmd() (in trunk/subversion/libsvn_repos/hooks.c):
>
> static const char* const check_extns[] = {
> #ifdef WIN32
> /* For WIN32 we need to check with an added extension(s). */
> ".exe", ".cmd", ".bat", /* ### Any other extensions? */
> #else
> "",
> #endif
> NULL
> };
>
>May I suggest that .py and .pl would be sensible extensions on Windows?
>
>
You may, but I disagree. We should either support the lowest common
denominator for executables on Windows platforms (which we're doing
now), or support _all_ registered executable extensions, either via the
%PATHEXT% envoronment variable, or based on information in the registry.

I'd support including a patch for the latter solution in 1.0.1, if the
implementation is reasonably isolated from non-platform-specific code.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org