[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Messages from hooks

From: Marcin Kasperski <Marcin.Kasperski_at_softax.com.pl>
Date: 2004-02-19 16:25:33 CET

Dnia czw 19. lutego 2004 16:06, Juanma Barranquero napisał:
> On Thu, 19 Feb 2004 15:34:40 +0100
> Marcin Kasperski <Marcin.Kasperski@softax.com.pl> wrote:
> > I think it would be good idea if the hook could somehow give
> > an error message which would be presented to the client.
> In svn:// and file:// cases (svnserve and local access), you
> already get the STDERR of the hook:

If I understand correctly, for serious/large/distributed
development one is to use http access. And those are the cases
when custom hooks are used more frequently than in small&simple

> D:\> svn propset --revprop svn:log -r 3 "Test message."
> http://localhost/test svn: DAV request failed; it's possible
> that the repository's pre-revprop-change hook either failed or
> is non-existent
> svn: At least one property change failed; repository is
> unchanged
> Allowing that would need to develop a protocol to send that
> info back to the client, and that's non-trivial,

I can't comment on the protocol but doesn't it possess some way
of telling the client what error has happened (even in non
hook-related case)?

> and perhaps even unneeded.

Imagine complicated commit hooks which (for instance) require
some special format of commit message (there is a frequent
example of bug number while commiting in stable branch), check
some special permissions, check the file format (for instance
'no win-1250 HTML please, use iso-8859-2), ... So someone
commits. The commit fails. What happened?

> After all, the hook could send
> e-mail on failure, or write a log somewhere...

log solution is obviously wrong, in the serious installation no
developer has access to the log.

email also does not seem to be good fit. Even leaving the problem
whom to send this email, this really does not seem to be natural
to run command line utility and then check the inbox. And email
does not always come immediately.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 19 16:25:55 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.