On Wed, Feb 18, 2004 at 07:10:03PM -0800, Daniel Rall wrote:
> Ben Reser wrote:
> ...
> >We're already requiring 5.8 for the Windows build and for Perl SWIG
> >support. Considering that 5.6.1 has been available for almost 3 years
> >now. I don't think this is a serious consideration.
> >
> >But the problems with -w and $^W are real. We've had a good solution to
> >this problem for 3 years. It's time to bury this skeleton. I'll add a
> >require 5.6.1; to make it clear why it's failing for those still using
> >5.005.
> >
> >Patch will be forthcoming...
>
> require 5.6.1; # minimum Perl version for "warnings" module
> use warnings;
>
>
> Sounds good. Planning on putting that in 1.0.x as well? The use of $^W
> makes us better off than we were before (non-functional), but not nearly in
> as good a shape as the above.
Patch attached:
[[[
Better way of handling warnings in perl scripts.
* tools/hook-scripts/commit-access-control.pl.in
* tools/hook-scripts/propchange-email.pl.in
* tools/hook-scripts/commit-email.pl.in
Use warnings pragma and require perl 5.6.1 or newer.
]]]
--
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 19 06:55:20 2004