Re: svn commit: r8621 - in branches/1.0.x: . tools/hook-scripts

Branko Čibej wrote:
> dlr@tigris.org wrote:
>
>>Author: dlr
>>Date: Thu Feb 12 04:07:35 2004
>>New Revision: 8621
>>
>>Modified:
>> branches/1.0.x/STATUS
>> branches/1.0.x/tools/hook-scripts/commit-access-control.pl.in
>> branches/1.0.x/tools/hook-scripts/commit-email.pl.in
>> branches/1.0.x/tools/hook-scripts/propchange-email.pl.in
>>Log:
>>Backport Blair's r8539 and r8540 commits to fix the shebang lines
>>which were preventing some scripts from running:
>
> I thought we'd agreed that setting the value of ^W not the right
> solution, and "use warnings" was the right one. How come this change got
> onto the 1.0.x branch?

I thought this patch fixed the bug (scripts not running because shebang lines can't have that many arguments) by replacing the "-w" command-line switch with a "^W" within the script, which has the same effect as the "-w" switch but actually works.

And then I thought there was a comment which said that use of "-w" or "^W" was not the best way to achieve the desired effect. But this second thing is an independent improvement, whereas the patch that got applied already was a "correct" bug fix (in that it fixes the bug and makes nothing any worse than it was).

(But I am unfamiliar with perl and may have misunderstood.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 16 19:05:57 2004