Re: [PATCH] Add verbose support to blame

On Mon, 16 Feb 2004 00:31:20 -0600, Ben Reser <ben@reser.org> wrote:
> Actually on further thought this implementation is completely wrong.
> The blame receiver already gets the date. Output options don't belong
> in our API, we're calling a receiver for the client to implement the
> output anyway it chooses.

You're right. When I was writing this patch, I was looking at
log_message_receiver(), which takes a hash of changed paths. Upon closer
examination, I see that changed_paths isn't really an output option; it's just
additional information provided to the receiver.

I should have been looking at something like add-cmd.c, which pulls the options
out of the baton.

> b) One blame receiver and it uses the baton we provide to pass the
> verbose flag through.

This is what I was trying to accomplish with my patch.

-- 
Ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org