Re: invalid XML on PROPFIND?

Julian Reschke wrote:

> Hi,
>
> out of curiosity I just did a PROPFIND on
>
> http://svn.collab.net/repos/svn/trunk
>
> MSXML complains immediately about:
>
> <C:svk:merge>ae6c956b-9dc6-0310-97b2-e73af4192982:/svn/local:7798</C:svk:merge>
>
>
> ...and I think it's right, in XML+Namespaces we have
>
> <http://www.w3.org/TR/REC-xml-names/#ns-qualnames>
>
> that is both the prefix and the local name must not have a column.

Ok, after checking on xml-dev this *definitively* is a bug.

The namespace declaration is:

        xmlns:C="http://subversion.tigris.org/xmlns/custom/"

which is correct, but

<C:svk:merge>ae6c956b-9dc6-0310-97b2-e73af4192982:/svn/local:7798</C:svk:merge>

uses an illegal local name "svk:merge" (illegal because it contains a
column).

So

1) if a custom property with an illegal XML name happens to appear
inside SVN's storage, it MUST NOT be sent in a PROPFIND response,

2) it should be checked why the XML parser inside the svn client does
not reject the XML (possibly running in non-namespace-aware mode???).

3) it should be prevented that customer properties with invalid XML
names are entered in the first place.

Should I enter this on the Issue Tracker?

Regards, Julian

-- 
<green/>bytes GmbH -- http://www.greenbytes.de -- tel:+492512807760
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org