[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] tools/xslt/svnindex.xsl and tools/xslt/svnindex.css

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-02-13 22:33:13 CET

Ben Collins-Sussman wrote:

>On Thu, 2004-02-12 at 10:34, Julian Foad wrote:
>>Ævar Arnfjörð Bjarmason wrote:
>>>It was pointed out to me that the patch was kinda crappy regarding
>>>indent , so i fixed that, use this instead.
>>>Oh, and one minor css error fixed
>>This patch is not in my area of expertise, but I just want to point
>>out that people will like it better if you also provide a log message
>>as described in the 'HACKING' file.
>Heh, who *is* qualified to review this patch? Who wrote the original
>.xsl and .css sheets? Time for 'svn log'...
I am, probably a few others. I just don't see it as terribly
high-priority, so I didn't even put it on my todo list yet. However,
since I'm writing this reply anyway...

>--- /home/share/software/src/subversion/tools/xslt/svnindex.xsl 2004-01-24 17:10:06.000000000 +0000
>+++ /home/jeedo/www/projects/svn_style/svnindex.xsl 2004-02-12 20:22:33.000000000 +0000
>@@ -15,13 +15,13 @@
> </xsl:if>
> <xsl:value-of select="index/@path"/>
> </title>
>- <link rel="stylesheet" type="text/css" href="/svnindex.css"/>
>+ <link rel="stylesheet" type="text/css" href="/projects/svn_style/svnindex.css"/>

This change is not necessary. I understand that you made it in order
that you can test on your system, but it has no place in the patch itself.

>@@ -48,29 +48,30 @@
> <xsl:text>Revision </xsl:text>
> <xsl:value-of select="@rev"/>
> </xsl:if>
>- </div>
>- <div class="path">
>- <xsl:value-of select="@path"/>
>- </div>
>- <xsl:apply-templates select="updir"/>
>- <xsl:apply-templates select="dir"/>
>- <xsl:apply-templates select="file"/>
>+ </h1>
>+ <ul id="list">
>+ <li>
>+ <div class="pathname"><xsl:value-of select="@path"/></div>
>+ <ul>
>+ <xsl:apply-templates select="updir"/>
>+ <xsl:apply-templates select="dir"/>
>+ <xsl:apply-templates select="file"/>
>+ </ul>
>+ </li>
>+ </ul>
> </xsl:template>
I disagree. The list title is not part of the list.

>- <xsl:text>Parent Directory</xsl:text>
>+ <xsl:text>..</xsl:text>
Oh really, this is so totally a bikeshed, it doesn't seem worth changing.

And, how about a patch for the CSS file, too? We want to keep both in sync.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 13 22:33:27 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.