[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: small bug: svn mv looses the hidden attribute

From: <brane_at_xbc.nu>
Date: 2004-02-11 18:44:15 CET

Quoting Ben Collins-Sussman <sussman@collab.net>:

> On Tue, 2004-02-10 at 13:25, SteveKing wrote:
> > if you rename a folder with
> >
> > svn mv original_foldername new_foldername
> >
> > then the .svn folder inside the 'new_foldername' folder looses (or
> > better: never gets set) the hidden attribute in windows.
> > This is a little inconsistent because usually those folders are hidden.
>
> Ha, sure enough, look at the comment within
> svn_io_copy_dir_recursively(). (libsvn_subr/io.c:471)
>
> The function is just calling apr_dir_make() to create new directories
> in the target, whereas for files it's calling svn_io_copy_file(), which
> seems to have a special win32 section to preserve file perms (!)

Bork!

1) This functionality should go into APR, but in the meantime, fixing the
directory creation on Windows should be simple. Could somebody please post a
1.0.1 issue with my name on it?

2) "svn mv" shouldn'd have to copy files around if it's only renaming a
directory. It should just rename the dir and update the entries files.

3) We need a new libsvn_wc.

4) So what else is new...

    Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 11 18:44:47 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.