[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bogus comment in subversion/libsvn_client/status.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2004-02-06 14:27:21 CET

Florian Weimer wrote:
> The comment directly contradicts the code. Looks like a cut'n'paste
> error.

I agree, but ...

> Index: subversion/libsvn_client/status.c
> ===================================================================
> --- subversion/libsvn_client/status.c (revision 8550)
> +++ subversion/libsvn_client/status.c (working copy)
> @@ -101,8 +101,8 @@
> sb.real_status_baton = status_baton;
> sb.deleted_in_repos = FALSE;
>
> - /* Need to lock the tree as even a non-recursive status requires the
> - immediate directories to be locked. */
> + /* First checks do not require a repository lock. We will subsequently
> + reopen the repository with a lock. */
> SVN_ERR (svn_wc_adm_probe_open (&adm_access, NULL, path,
> FALSE, FALSE, pool));

... the lock is on the working copy tree, not on the repository.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 6 14:26:13 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.