Re: Arguments to pre-revprop-change-hook when running svnadmin setlog

Juanma Barranquero <jmbarranquero@wke.es> writes:

> I already mentioned the problem in a message on users@ about two months
> ago, with no answer. That message contained two issues and the first one
> was discussed, so I'm not claiming I was ignored, just that the second
> issue went unnoticed :)

That happens from time to time.

> Summary: I want to do "svnadmin setlog" and change the log message for a
> given revision, *running* the pre-revprop-change hook. I can't. The
> problem is that I cannot get pre-revprop-change hooks to receive four
> arguments (as the docs state) when invoked through "svnadmin setlog".
> The hook runs fine via "svn propset svn:log --propset", but "svnadmin
> setlog" does not send the username.

You are absolutely right. And now you've explained a mystery to me --
why I get propchange emails from "@tigris.org". When I added the
--bypass-hooks and made svnadmin use the hooks system by default, I
must have just punted on the author issue (as you can see, I pass NULL
for that argument in svnadmin/main.c:737).

So... what's the solution? Do we pass a static name like "svnadmin"
through as the username? Do we get the UID of the current user?

I'm thinking that the best thing to do is to add a --username option.
And should it be a required parameter when not bypassing hooks? I
dunno...

Thoughts, anyone?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 5 16:14:18 2004