Note that Josander is rolling 0.37 around 6pm his time tomorrow (I
think he's in the European GMT+1 timezone).
It's terribly bad form for me to suggest that developers review and
vote on changes at the last minute. But I'm going to anyway, because
the changes in question are mostly very small and low-risk (with the
exception of r8463, which looks big although it's actually not
complex, and prevents a really stupid bug). Also, some of these
changes got held up by unexpectedly long discussions settling on
unexpectedly small tweaks. Seems a shame, etc, etc.
So:
* Issue #1705 (patch 291)
Change blame receiver's line_no argument from apr_off_t to apr_int64_t.
Votes: +1: ghudson, kfogel
* Issue #1713
Change svn_filesize_t to signed, for consistency and SVN_INVALID_FILESIZE
Votes: +1: ghudson, kfogel
Those two are the unexpectedly small result of the apr_off_t thread
(the other result is discussion on dev@apr, at least for now). In
#1713's case, there are good reasons to do it independently of the
whole apr_off_t thing, and it's a truly tiny change.
* r8463 (fix for issue #1709)
Make mod_dav_svn stop spewing huge responses at dead sockets.
Votes: +1: cmpilato, kfogel
You may recall from the dev@ list that there's still a bug where
hitting ^C on the client side doesn't correctly shut down the socket.
But having r8463 on the server side is much more important -- it means
when we get the ^C bug fixed on the client side, servers will be ready
to Do The Right Thing. So I think this is worth having. (I'm not
sure I agree with the DoS claim in STATUS, because the DoS attack is
still there -- all the attacker has to do is not shut down the socket.
But it's still a stupid bug with ugly server-side consequences.)
* r8139
Fix authentication bugs.
Votes: +1: ghudson
I'm not particularly advocating r8139, but if Tobias (bliss) thinks it
should have gone in, and was just missed because of an oversight, then
I hope he'll vote for it as early as possible tomorrow. I'll watch
for such a change, and any mails from him.
Finally, there's this:
* r8368, r8417, r8418, r8438, r8439, r8440, r8441, r8442
Support SWIG 1.3.20 and newer and require at least 1.3.19.
Justification: An increasingly common version of SWIG that we
need to support. And have proper requirements.
Votes:
+1: breser
+1 (concept and build system changes): ghudson
Personally, I've had a greater-than-random tendency to miss mistakes
in build system changes :-), so I'm reluctant to provide a +1 on this
if others more competent can review it. I'll check back tomorrow
morning and see if anyone has had a chance. (Remember, the build
system portion needs three +1's, and only has Greg Hudson's right
now.)
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 24 08:07:20 2004