Re: [Issue 1705] apr_off_t is of an ambiguous size

On Fri, 2004-01-23 at 01:44, Ben Reser wrote:
> I've converted it using svn_io_file_seek there but read_chunk (and a
> bunch of the libsvn_diff interface) didn't take a pool argument. This
> lead to some changes needed to the API for libsvn_diff.

I have reviewed this carefully, made sure it compiles without warnings
on my system, and made sure it passes "make check". So, consider my +1
in the STATUS file to be up to date.

Hopefully bliss will remove his veto and vote for the patch. We need
one more person; people can read

  http://marc.theaimsgroup.com/?l=apr-dev&m=107481332607151&w=2

for my explanation of why library APIs should avoid using off_t. (That
mail is written in an APR context, but it applies equally well to
Subversion.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 23 19:17:44 2004