[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svncpp crash in ssl_server_trust_file_save_credentials

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-01-22 15:36:03 CET

Barry Scott wrote:
> At 21-01-2004 13:42, Tobias Ringstrom wrote:
> Let me check I understand.
> With a well designed GUI the store-auth-creds in the config file is not
> required.

Sure. I wanted to remove the whole option, but the idea met some
resistance. Since we are stuck with the option, it's good to indicate to
the user that saving has been globally disabled.

> I have this in my config:
> [auth]
> store-password = no
> store-auth-creds = no
> and may_save is passed in as 1 when I access a repo via HTTP:
> that needs a username/password.

It could be that your client does not check the config file and updates
the auth parameters as the cmdline client does, i.e.

     /* There are two different ways the user can disable disk caching
        of credentials: either via --no-auth-cache, or in the config
        file ('store-auth-creds = no'). */
     if ((err = svn_config_get_bool (cfg, &store_password_val,
       svn_handle_error (err, stderr, TRUE);
     if (opt_state.no_auth_cache || !store_password_val)
       svn_auth_set_parameter(ab, SVN_AUTH_PARAM_NO_AUTH_CACHE,
                              (void *) "");

This should really be done by libsvn_subr, but fixing that requires
another API change. Sussman and I discussed this problem on IRC a week ago.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 22 15:36:44 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.