[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix gen-make.py Python 1.5.2 compatability

From: <subversion_at_millenix.mailshell.com>
Date: 2004-01-18 20:38:03 CET

David Summers wrote:
> Not knowing hardly any python, here is my first attempt at a patch to
> gen-make.py to bring it back to Python 1.5.2 compatability. This fixes
> the bug introduced in r8109. This bug was keeping the RedHat 7.3 RPM from
> being built.
>
> Log:
> ====
> * gen-make.py : Fix issue with Python 1.5.2 compatability.
>
> Index: gen-make.py
> ===================================================================
> --- gen-make.py (revision 8372)
> +++ gen-make.py (working copy)
> @@ -156,9 +156,9 @@
>
> # Remember all options so other scripts can use them
> opt_conf = open('gen-make.opts', 'w')
> - print >> opt_conf, "[options]"
> + opt_conf.write( '[options]' )
> for opt, val in rest.list:
> - print >> opt_conf, opt, '=', val
> + opt_conf.writeline( opt, '=', val )
> opt_conf.close()
>
> if gentype not in gen_modules.keys():

This patch cannot possibly be correct. To replace a single construct
("print >> opt_conf"), you use 2 different new constructs, opt_conf.write()
and opt_conf.writeline(). Which is it?
Perhaps someone with python experience can clear this up.

Philip Miller

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jan 18 20:38:55 2004

This is an archived mail posted to the Subversion Dev mailing list.