Re: apr_off_t is of an ambiguous size.

Ben Reser wrote:

>On Sat, Jan 17, 2004 at 06:08:29PM -0500, Greg Hudson wrote:
>
>
>>I think I'd rather we just hide our heads in the sand and assume that
>>svn_offset_t is at least as big as apr_off_t. If we ever run into
>>128-bit apr_off_t values and people want to use >64-bit offsets, we're
>>in more trouble than we can really solve with a bounds check here.
>>
>>
>
>But we already know that this isn't true. Out of the box on 32-bit
>archs running Linux apr_off_t is going to be a 32-bit int.
>
Not on Windows, where apr_off_t is always 64-bit.

>svn_offset_t is 64-bits on all platforms.
>
If anyone takes the time to make this a complete patch, please don't
introduce svn_offset_t. Use the existing svn_filesize_t. Yes, I know
that's unsigned, but we can fix that (i.e., either make it signed, or
tell svn_io_file_seek of we're seeking backwards or forwards from the
current position). But I don't want to see two different types.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org