[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_off_t is of an ambiguous size.

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-01-18 03:13:42 CET

On Sat, 2004-01-17 at 21:10, Ben Reser wrote:
> On Sat, Jan 17, 2004 at 06:08:29PM -0500, Greg Hudson wrote:
> > I think I'd rather we just hide our heads in the sand and assume that
> > svn_offset_t is at least as big as apr_off_t. If we ever run into
> > 128-bit apr_off_t values and people want to use >64-bit offsets, we're
> > in more trouble than we can really solve with a bounds check here.
>
> But we already know that this isn't true. Out of the box on 32-bit
> archs running Linux apr_off_t is going to be a 32-bit int. svn_offset_t
> is 64-bits on all platforms.

And, last I checked, 64 is at least as big as 32.

The first check is fine. The second check (before stuffing the APR
offset back into the parameter) seems needless.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jan 18 03:14:12 2004

This is an archived mail posted to the Subversion Dev mailing list.