[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_load_dirs update

From: Peter Gervai <grin_at_tolna.net>
Date: 2004-01-17 13:35:38 CET

On Fri, Jan 16, 2004 at 12:39:02PM -0800, Blair Zajac wrote:
> > * new option -g: draw lines in selection
> > * Yes is default selection
> > * All option in selection listing apart from Y/N
> > * possibility to relist at the end of the selection
> > * selection is sorted by filename
> >
> > Please apply!
> >
> I've got your patch merged into my working copy.

Thanks.

> I've removed
> the -g option to always use _'s to match up the columns.

I put it in an option because there were objections last time (half a year
ago?) when I first submitted patches against this code. Fine with me, I
would have used it always anyway.

> What was the intent of the 'a' answer? Was this just to print
> all of the added and deleted files at once?

[and you asked in the next mail for something more subtle]

The point was to let the list go on till the end without requiring user to
press Y+enter 30+ times. So far I can only start 'script -f name', run the
full list, and see the numbers in the log...

Default answer is fine, I'm preparing a patch.

> BTW, next time you submit a patch, please observe the code style
> in the file as this reduces the amount of time to clean up the
> patch.

*sigh* Okay. Sorry.

grin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 17 13:36:17 2004

This is an archived mail posted to the Subversion Dev mailing list.