[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn 0.34.0, 0.35.1 windows access is denied on delete directory

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-01-16 18:16:32 CET

"D.J. Heap" <dj@shadyvale.net> writes:

> it *is* kind of an ugly preprocessor macro

That was my initial reaction, but after reading the patch I think it's
cleaner than the existing code. I'll approve it for the trunk. I
suggest you propose it in the STATUS file for 1.0-branch, I don't
think we want 1.0 to produce 'access denied' errors.

> Log:
> Factor the Window's retry loops into a macro and add the loops to
> a couple of more places where 'access denied' errors have been
> reported.

That duplicates too much of the text below, just say something like:
  Fix some more 'access denied' errors on Windows.

> * subversion\libsvn_subr\io.c

Use / rather than \ to match the other log messages.

> (svn_io_file_rename, svn_io_remove_file, svn_io_remove_dir,
> svn_io_dir_remove_nonrecursive): Factor out the Windows
> retry loop into a macro and add it to the directory
> removal functions.

Add something like:
     (WIN32_RETRY_LOOP): New macro.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 16 18:18:31 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.