[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: no more need for a mergemaster

From: Greg Stein <gstein_at_lyra.org>
Date: 2004-01-16 11:31:56 CET

On Thu, Jan 15, 2004 at 07:45:46PM -0600, kfogel@collab.net wrote:
> Please use appropriate judgement about controversial items. For
> example, r8339 was pretty obvious, so I didn't feel a need to wait a
> day for potential vetoes when it had three votes. On the other hand,
> if a big change (such as the apr_off_t stuff) were to get three +1's
> within five minutes of being put in STATUS, that doesn't mean it
> should be merged right away. Give people a day or so to examine it
> first :-).

There is no such thing as a statute of limitations -- there isn't a rule
that says "well, it has been in there for X days, or Y months, so it gets
to stay". Bad code is bad code. So even though some code is committed, it
can *still* be vetoed and pulled back out.

Regardless... yes, it is polite to at least give people 72 hours to review
a vote. That is usually sufficient time for people to see the issue --
despite whatever time zone they may be in, or whatever personal time sink
has pulled them away.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 16 11:37:58 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.