[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_off_t is of an ambiguous size.

From: Russell Yanofsky <rey4_at_columbia.edu>
Date: 2004-01-15 12:24:09 CET

Ben Reser wrote:
> On Tue, Jan 13, 2004 at 04:07:57AM -0500, Russell Yanofsky wrote:
>> Is it possible to just strip out -D__USE_FILE_OFFSET64 from what it
>> returns? Or do the perl APIs use off_t in their own interfaces?
>
> Depends on which IO interface you use. There's several of them.
> I don't think it would create any problems for the perl bindings to
> strip that. But I don't think it solves the problem. It hides it for
> one situation that happens to be easier to work around and does
> nothing
> for the rest.

I agree. The subversion libraries and APR should be hardened to provide a
consistent interface on any given platform regardless what runtime library
or library options they are used with. And the changes you propose at

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=54363

would be desirable even if this issue didn't exist.

It sounds like perl gives extension writers some leeway in this area. I'd
say if that if you aren't forced to build your extension
with -D_FILE_OFFSET_BITS=64 (or -D__USE_FILE_OFFSET64 or whatever) then,
in the name of all that is good and holy, don't do that. But that's up to
you, and your patch for subversion will probably make the issue moot.

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 15 12:22:01 2004

This is an archived mail posted to the Subversion Dev mailing list.