[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8253 - trunk/subversion/svnlook

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-01-13 15:00:36 CET

kfogel@collab.net wrote:
> bliss@tigris.org writes:
> >+/* Create a new temporary directory with an 'svnlook' prefix. */
> >+static svn_error_t *
> >+create_unique_tmpdir (const char **name, apr_pool_t *pool)
>
> At some point, I think we'd want this to become a public api,
> analogous to svn_io_open_unique_file().
>
> Actually, now that I think about it, is there any reason not to make
> it a public function right now? Avoiding API divergence between 1.0
> and trunk is more about not changing existing functions -- but adding
> a new function on trunk, even if it doesn't go into 1.0? Sure, I
> don't see a problem with that...

I thought about it and decided to be conservative, partly becuse I'm not
conviced that it's a very useful function. Now I'm actually wondering
why svnlook creates a temporary directory at all. It only seems to
operate on a pair of temporary files anyway, so why does it create a
whole directory? I'm guessing that there are historical reasons for this...

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 13 15:01:14 2004

This is an archived mail posted to the Subversion Dev mailing list.