[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: apr_off_t is of an ambiguous size.

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2004-01-13 01:49:18 CET

On Mon, Jan 12, 2004 at 01:45:06PM -0800, Greg Stein wrote:
>
> I'd go with apr_uint64_t rather than svn_filesize_t. This is a line number
> rather than an offset/size of a file. Yes, the two are proportional to
> some degree, but I'd agree with ghudson about the "mental judo" if we used
> svn_filesize_t for that param.
>

It is a line number, but it is also implicitly the same datatype as the
results of svn_diff_file_diff(), which uses apr_off_t.

What are we going to do about apr_off_t in public interfaces in general,
rather than in this specific case?

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 13 01:49:59 2004

This is an archived mail posted to the Subversion Dev mailing list.