[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Manually invoking post-commit works, svn-invoking post-commit doesn't

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-01-12 14:50:44 CET

On Mon, 2004-01-12 at 04:29, Stuart Robertson wrote:

> The requirement for 'svnlook diff' to be run from directory to which it has
> write permissions should perhaps be documented somewhere. Or, the svnlook
> should perhaps be updated to write to create temporary files in /tmp and not
> try to write directly to the working directory.

Actually, we've known about this bug for a long time, and have been
waiting for APR to grow a function that returns an OS-specific tmpdir.
APR *has* that function now, so it would be trivial to make svnlook's
main.c use that function instead of this current code:

/* Temporary subdirectory created for use by svnlook. ### todo: we
   need to either find a way to query APR for a suitable (that is,
   writable) temporary directory, or add this #define to the
   svn_private_config.h stuffs (with a default of perhaps
"/tmp/.svnlook" */
#define SVNLOOK_TMPDIR ".svnlook"

Anyone wanna submit a patch?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 12 14:51:17 2004

This is an archived mail posted to the Subversion Dev mailing list.