[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: branch 1.0-stabilization: All my tests passed, how about yours? ;-)

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-01-11 15:05:21 CET

Philip Martin wrote:
> Another problem is spurious username prompts:
>
> $ grep ^store ~/.subversion/config
> store-password = no
> store-auth-creds = no
> $ svnadmin create repo
> $ svn mkdir -m "" file://`pwd`/repo/foo
> Authentication realm: 7b19ef9d-98d0-0310-9904-a7f57b3cb904
> Username:
>
> I don't think I should be prompted for a username here; I definitely
> don't get prompted if I use the trunk.

Absolutely correct, and it's my fault. It does not happen on trunk
because r8139 (which is not included in 1.0) "accidently" fixed this
as well. The following patch fixes it:

Index: subversion/libsvn_client/username_providers.c
===================================================================
--- subversion/libsvn_client/username_providers.c (revision 8233)
+++ subversion/libsvn_client/username_providers.c (working copy)
@@ -312,7 +312,7 @@

    SVN_ERR (prompt_for_username_creds
             ((svn_auth_cred_username_t **) credentials_p, pb,
- parameters, realmstring, ! no_auth_cache, TRUE, pool));
+ parameters, realmstring, TRUE, ! no_auth_cache, pool));

    ibaton->retries = 0;
    ibaton->pb = pb;

Things works a lot better when you pass the parameters in the right
order. I'll put this is an issue so we can vote for it.

/Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jan 11 15:05:56 2004

This is an archived mail posted to the Subversion Dev mailing list.