[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r8085 and r8104

From: Ben Reser <ben_at_reser.org>
Date: 2004-01-08 03:20:38 CET

On Wed, Jan 07, 2004 at 02:11:58PM -0600, kfogel@collab.net wrote:
> David, I can change my vote to a real +1 if you can confirm to me that
> "%{__perl}" lines in the patch work exactly as intended. That's the
> one part I didn't feel competent to review, but I'm happy to go out on
> a limb for you if you've tested this :-). Also, you might want to
> vote on this item yourself!
>
> One thing:
>
> In those two revisions, part of the patch looks like this:
>
> +# Start patch by Ben Reser <ben@reser.org> to get documentation to build.
> +%{__perl} -pi -e [...]
> +%{__perl} -pi -e [...]
> +# End patch by Ben Reser <ben@reser.org> to get documentation to build.

I can confirm that they work on Mandrake. The lines are identical to my
Mandrake spec file. As long as RedHat defines the macros (%{__perl} and
%{_datadir}) and places their stylesheets in the same place then this
should work fine. But then my review of my own code isn't of much use.
:)

> For the future: when applying a patch, you can take out the markers
> left by the contributor, and (if appropriate) replace them with a more
> timeless comment, for example:
>
> +# Build documentation.
> +%{__perl} -pi -e [...]
> +%{__perl} -pi -e [...]

I'll note that the comments didn't come from me. I never generated a
diff. I just copied the lines out of my spec file for Mandrake and
pasted them into an email. At any rate the comment in my Mandrake spec
is:
# the perl script works around a bug in the html-stylesheet.xsl

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 8 03:21:11 2004

This is an archived mail posted to the Subversion Dev mailing list.