[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adding cancellation support to svnadmin and svnlook

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-01-08 00:05:31 CET

On Jan 6, 2004, at 6:15 AM, Tobias Ringström wrote:

> The attached patch adds cancellation support to svnadmin and svnlook.
> Pressing ctrl-c when using these programs will wedge the repository
> without this patch.
>
> The patch also ignores SIGPIPE for svnadmin, svnlook and svn.
> Redirecting the output through a pipe to e.g. more will wedge the
> repository without this patch if more is terminated. Running a command
> on a remote machine will cause the same problem if the connection is
> terminated.
>
> I doubt that many of our users understand that pressing ctrl-c during
> "svnadmin verify" or running "svnlook cat" through more and quitting
> more can cause the repository to wedge. It's a sneaky problem.
>
> We do have a lot more negative user experience that we deserve because
> repositories get wedged much too easily. The most common problem is
> likely the permission problem, but the problems that the attached
> patch fixes are also common.
>
> This patch does not fix all problems, but many of them. I'll bring up
> the rest that I know of in separate emails.
>
> Unless I get a lot of negative feedback I plan to put this in an issue
> and make it a 1.0 vote. I wanted to post it here first to make it
> easier for you all to look at the patch and give comments.

I don't have time to do an in-depth review, but this looks fine at
first glance, and you're quite right about this being a serious
problem. I'd like to see something like this in 1.0, if at all
possible.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 8 00:06:07 2004

This is an archived mail posted to the Subversion Dev mailing list.