[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix documentation link for svn_dirent_t

From: Greg Stein <gstein_at_lyra.org>
Date: 2004-01-07 13:50:30 CET

On Mon, Jan 05, 2004 at 08:17:45PM -0800, Ben Reser wrote:
>...
> I'll point out that we're not following GNU style on the struct
> definitions. Which says:
> "Don't declare both a structure tag and variables or typedefs in the
> same declaration. Instead, declare the structure tag separately and then
> use it to declare the variables or typedefs." [1]

Bleh. C allows you to flow 'em together, so why make extra work for
yourself... Well, for typedefs at least. I agree that variables shouldn't
be declared along with the struct declaration (tho I have defined
variables (global constants) using unnamed/untypedef'd structs).

> I have no idea why they decided that, but I did not change to follow
> their style. But I mention it because it may be useful to add something
> to HACKING to specify which style we prefer here since we're doing
> something different than the GNU standard.

Personally, I prefer to avoid struct tags altogether. I use them only for
forward refs or other kinds of recursive/self linking.

I don't use gdb, so I'm not familiar with ghudson's comment on the utility
of the struct tag over the typedef. If there *is* some utility, then I'd
be +0 on adding them for gdb users.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 7 13:55:47 2004

This is an archived mail posted to the Subversion Dev mailing list.